glitch-soc / mastodon

A glitchy but lovable microblogging server
https://glitch-soc.github.io/docs/
GNU Affero General Public License v3.0
706 stars 182 forks source link

Customisable web composer emoji search limit #2670

Open ShadowJonathan opened 8 months ago

ShadowJonathan commented 8 months ago

Currently, the limit is 75, but it's not too easily configurable, needing the following addon in both emoji_picker_dropdown.jsx files:

        <EmojiPicker
          perLine={8}
          emojiSize={22}
          sheetSize={32}
+         maxResults={250}

And also the version of emoji mart to change from @stable to @beta in package.json:

-   "emoji-mart": "npm:emoji-mart-lazyload@stable",
+   "emoji-mart": "npm:emoji-mart-lazyload@beta",

(Because the critical version that enables setting maxResults up above has only been released as "beta" on npm)

(For anyone doing this to patch their install; run yarn install once to update the yarn.lock file)

(Btw, the project has had its last update 3 years ago, I'm not entirely sure if thats good for maintenance)

IMO this could be more easily configurable.

ClearlyClaire commented 8 months ago

I am not comfortable with using a different version of a dependency that upstream already uses. (Though it is planned to replace the emoji picker upstream one day)

ShadowJonathan commented 8 months ago

I wasn't really suggesting to do that, just more putting down instructions for anyone else on how to mod their server this way, and/or giving some idea of what it takes to make it configurable.

But if its going to be replaced, then these instructions would be moot at that point 👍