vburwitz3
commented
6 years ago My request code it the following
private async void startBinanceConnection (bool requestUnderlyings) {
// Binance init
binanceClient =new BinanceClient(new ClientConfiguration() {
ApiKey =binanceApiKey,
SecretKey =binanceSecretKey,
Logger =logger,
DefaultReceiveWindow =50000,
});
// init callbacks and start
UserDataWebSocketMessages userDataWebSocketMessages =new UserDataWebSocketMessages {
OrderUpdateMessageHandler =new BinanceWebSocketMessageHandler<BinanceTradeOrderData>(x => {
// OrderStatusUpdate() als EventHandler callen um Orderänderungen zu verarbeiten
MethodInvoker orderStatusUpdateCall =delegate {
OrderStatusUpdate(x);
};
Form1.gui.Invoke(orderStatusUpdateCall);
}),
TradeUpdateMessageHandler =new BinanceWebSocketMessageHandler<BinanceTradeOrderData>(x => {
// OrderStatusUpdate() als EventHandler callen um Trade Executions zu verarbeiten
MethodInvoker orderStatusUpdateCall =delegate {
OrderStatusUpdate(x);
};
Form1.gui.Invoke(orderStatusUpdateCall);
}),
AccountUpdateMessageHandler =new BinanceWebSocketMessageHandler<BinanceAccountUpdateData>(x => {
Console.WriteLine("AccountUpdateMessageHandler: eventType " +x.EventType+" balances "+x.Balances.ToString());
})
};
logger.Info("binanceWebSocketClient Callbacks starting...");
binanceWebSocketClient =new DisposableBinanceWebSocketClient(binanceClient, logger);
try {
binanceWebSocketClientGuid =await binanceWebSocketClient.ConnectToUserDataWebSocket(userDataWebSocketMessages);
}
catch (Exception ex) {
printMsgStatic("startBinanceConnection: ConnectToUserDataWebSocket failed (Exception: "+ex.Message+").");
}
logger.Info("binanceWebSocketClient Callbacks done.");
if (requestUnderlyings) {
printMsgStatic("Underlyings Requests start.");
// alle Underlyings neu requesten
for (int undID=0; undID<indexEntries.GetLength(0); undID++) {
Underlying und =(Underlying)symbols[undID];
// Realtime Tickdaten für das Index Spot Underlying requesten
printMsgStatic("Start Binance realtime Request: "+und.underlying);
// Manual WebSocket usage
var socketId =binanceWebSocketClient.ConnectToTradesWebSocket(indexEntries[undID,indexSpot], b => {
Form1.updateLastBinance(b);
});
} // for (underlying)
printMsgStatic("Underlyings Requests done.");
}
} // startBinanceConnection()
xfiodembo
glitch100
Issue Overview
Sadly there is a problem that connections get constantly lost if you run a program 24h. I do not see how to get that solved. If there are no price updates for some time I can rerequest. But UserDataWebSocketMessages connection handlers die and I cant check them (at least I do not see how) (and price updates may still be coming and are not broken!). Sadly everything is wrapped up in a DLL so I can not go into the problem. Telegram API discussion group or Binance ticket was of no use. The real problem is there is no working function to check if connection is ok. At the beginning each order creation/deletion on binance comes over the connection, at a certain point it stops until a connection is newly recreated (new UserDataWebSocketMessages()). The problem is there is also no exception or so that would be thrown to get the information that connection is broken.
Package Version: ?.?.?
BinanceDotNet 4.6.2
Repro Steps
To check the issue simply do a connection with new UserDataWebSocketMessage(OrderUpdateMessageHandler, TradeUpdateMessageHandler, AccountUpdateMessageHandler) and try after some hours to get a order update, by example cancelling an existing order over the Binance website "Open Orders" page. Mostly after some hours the connection will have died and there will be no Update/Cancellation/Whatever message received by the client anymore.
Other Information
It is a very severe API issue! Since it basically prevents implementing a stable automated trading application!