search

glitchassassin / lackey

Lackey - Graphical desktop automation with Python
MIT License
616 stars 75 forks source link

Method waitVanish does not raise FindFailed exception after seconds timeout #150

Open vcher5 opened 5 years ago

vcher5 commented 5 years ago

The doc says: waitVanish(pattern, seconds=None)[source] Waits until the specified pattern is not visible on screen.

If seconds pass and the pattern is still visible, raises FindFailed exception. Sikuli supports OCR search with a text parameter. This does not (yet).

But it does not raise it because this line is commented out in the source code. `if match: return False

self._findFailedHandler(FindFailed("Pattern '{}' did not vanish".format(pattern.path)))

`

glitchassassin commented 5 years ago

This was corrected for Sikuli compatibility, but the documentation was not updated. The functionality itself is correct. Thanks for the catch!

glitchassassin commented 4 years ago

Fix has moved to develop