search

glittergallery / GlitterGallery

Share, collect feedback on, and view/manage design iterations.
MIT License
45 stars 33 forks source link

Adding turbolinks gem? #81

Closed charlesx2013 closed 10 years ago

charlesx2013 commented 10 years ago

Do you think we should include the turbolinks gem to the project? It'll save time because all our rendering and redirecting won't need to reload the JavaScript (which there is a lot of), and it'll make the website look like as if its pseudo ajax'ed. (No white screen when reloading a page)

rohitpaulk commented 10 years ago

Why not update to Rails 4 straight up? ( #74 )

charlesx2013 commented 10 years ago

No idea. Rails 4 would be a better option, seeing as some of the things that are in the application are a little outdated.

rohitpaulk commented 10 years ago

Give me a day, lemme try updating. Let's see what happens :metal:

sarupbanskota commented 10 years ago

Great! I think it would be good to upgrade to R4 at this point since the codebase isn't too big. Please let me know if there's anything I can help with.

rohitpaulk commented 10 years ago

@charlesx2013 , @sarupbanskota - I'm having an issue with Turbolinks. When I try to create a new drawing, the iframe that handles the drawing doesn't appear the first time I click on Draw. However, if I click back and then click on Draw again, it appears. I haven't been able to identify the error yet.

Here's the pull request for updating to Rails 4 - #84. For now, I've removed Turbolinks. And FYI, the issue is not only with Rails 4, it is with Turbolinks in general. i.e., the same problem occurred when we had the Turbolinks gem install on Rails 3.

If you can find a solution to this problem, do send in a PR :)

charlesx2013 commented 10 years ago

@rohitpaulk, @sarupbanskota I realized that sketchily might not be about to support turbolinks, although I'm sure there's a way to fix it if I look hard enough. Heres a quick fix for now: (#87) Hopefully we can find a way to make it less hacky.

rohitpaulk commented 10 years ago

@charlesx2013 - This should do! I should've thought of just disabling turbolinks on that one page. I'll update my Gemfile and push a commit once your changes are merged in :)

rohitpaulk commented 10 years ago

Looks like this issue can be closed now. ( #87 and #84 )

sarupbanskota commented 10 years ago

https://github.com/lml/sketchily/issues/14 Yes I was just following that thread and forgot.