search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
280 stars 84 forks source link

Installation command with python setup.py develop #254

Closed cxrodgers closed 6 years ago

cxrodgers commented 6 years ago

The README says to install with this command: python setup.py develop install

But I have always used this: python setup.py develop

Source: https://avolkov.github.io/installing-python-packages-in-development-mode.html

At least for me, the command in the README did not work -- I got "ImportError: No module named externals.six" -- but python setup.py develop did work. For what it is worth, I use python2 and conda to manage my installations, so this might change things.

Is there a reason to prefer python setup.py develop install in the README?

jasmainak commented 6 years ago

indeed @cxrodgers you are correct. Do you want to make a pull request to fix this.

ps: @pavanramkumar this is also probably the reason you were struggling with the installation the other day

cxrodgers commented 6 years ago

@jasmainak I created the PR. Note that the same instruction appears in the Makefile but I don't understand Makefiles so I didn't make any changes there.

jasmainak commented 6 years ago

closed by #255

jasmainak commented 6 years ago

Oops I merged too soon then :) But yeah I think the Makefile should be modified as well.