Closed pavanramkumar closed 6 years ago
@pavanramkumar make sure to update the Makefile
and all relevant docs as well (contributing.md etc.)
Merging #257 into master will increase coverage by
14.13%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #257 +/- ##
===========================================
+ Coverage 59.44% 73.58% +14.13%
===========================================
Files 7 4 -3
Lines 1339 617 -722
Branches 262 124 -138
===========================================
- Hits 796 454 -342
+ Misses 473 123 -350
+ Partials 70 40 -30
Impacted Files | Coverage Δ | |
---|---|---|
pyglmnet/pyglmnet.py | 79.46% <0%> (ø) |
:arrow_up: |
pyglmnet/externals/six.py | ||
pyglmnet/externals/funcsigs.py | ||
pyglmnet/externals/__init__.py |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 85be309...b14b452. Read the comment docs.
@pavanramkumar ready to merge?
@jasmainak
python setup.py develop
is the way to go here?python setup.py develop
is ok for virtualenvs such as travisCI environment: https://stackoverflow.com/questions/19048732/python-setup-py-develop-vs-installmerging.
@pavanramkumar : this still needs to be updated: https://github.com/glm-tools/pyglmnet/blob/master/Makefile#L5
regarding using python setup.py develop
, it's what we use in the other packages. Maybe the regular install may also work. It was just to debug -- as I thought maybe Travis caches your installation.
closes #256