Closed jasmainak closed 6 years ago
Merging #262 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 4 4
Lines 618 618
Branches 125 125
=======================================
Hits 451 451
- Misses 127 128 +1
+ Partials 40 39 -1
Impacted Files | Coverage Δ | |
---|---|---|
pyglmnet/pyglmnet.py | 78.68% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a7f3f2c...d309f79. Read the comment docs.
@pavanramkumar I'm done here. Let me know if I missed something. Or feel free to push directly to this branch.
@pavanramkumar it's funny how we didn't add many features but I'm quite happy about the improved test coverage and the refactoring. I think it's a good move in the long run and makes the library more robust.
@jasmainak
some more issues we solved, not sure where it belongs in the changelog:
@pavanramkumar the two contributions you mention are really important but I don't know if it belongs to this document. The whats_new.rst
is more for users who need to know what to look for in the new version. We could still add it if you want, so as to acknowledge the contributions.
Other comments addressed btw
thanks! LGTM once those two contribs are added.
Great, added.
closes #260
It's WIP. Since it's a little repetitive task, I'll finish it when I'm at the library later today.
We should make sure to update it before merging a pull request from now on.