[MRG+1] Fix issue #269.

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models

http://glm-tools.github.io/pyglmnet/

MIT License

279 stars 83 forks source link

Closed geektoni closed 5 years ago

geektoni commented 6 years ago

Changes summary

Update simulate_glm to use a RandomState instance initialized with random_state;
Update GLM to use a RandomState instance initialized with random_state;
Add a test to ensure correctness of the results when setting random_state (this may require a more close review);
Update what's_new.rst with the bugfix news.

jasmainak commented 6 years ago

@geektoni make sure to update whats_new.rst once you have addressed all the comments

geektoni commented 6 years ago

I've addressed the last comments and updated the whats_new file.

geektoni commented 5 years ago

Fixed naming issues. It should be ready now :)

jasmainak commented 5 years ago

Good to go for me. @pavanramkumar please merge if you're happy !

pavanramkumar commented 5 years ago

This is a super useful contribution! thanks @geektoni and thanks @jasmainak for thoughtful reviews.

jasmainak commented 5 years ago

@geektoni looking forward to your next contribution ;)