search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
280 stars 84 forks source link

Dependencies #280

Closed tommyod closed 5 years ago

tommyod commented 5 years ago

Added the major dependencies in install_requires.

Now users can do pip install pyglmnet and the dependencies will be installed automatically.

codecov-io commented 5 years ago

Codecov Report

Merging #280 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   73.74%   73.74%           
=======================================
  Files           4        4           
  Lines         617      617           
  Branches      124      124           
=======================================
  Hits          455      455           
  Misses        123      123           
  Partials       39       39
Impacted Files Coverage Δ
pyglmnet/pyglmnet.py 79.67% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09fdad1...d04d168. Read the comment docs.

tommyod commented 5 years ago

I've added a requirements.txt file, and extended testing to cover Python 3.6 and 3.7. I think it's important to test against these latest versions of Python explicitly.

tommyod commented 5 years ago

I understand your sentiment regarding pip automatically installing numpy/scipy, and have removed those lines. This PR now adds requirements.txt, testing for the latest two Python versions, simplified Travis setup, ignores some flake8 warnings causing test to fail currently, and installs without importing the package.

Ready to merge if you are :+1:

jasmainak commented 5 years ago

Merged, thanks a lot for the contribution!