glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models

http://glm-tools.github.io/pyglmnet/

MIT License

279 stars 83 forks source link

[work in progress] Dropping Python 2 support #286

Closed tommyod closed 5 years ago

tommyod commented 5 years ago

This PR closes #285 .

Removed Python 2 from Travis CI testing.
Removed the entire externals folder and associated code.
Removed base.py, importing from sklearn instead.

codecov-io commented 5 years ago

Codecov Report

Merging #286 into master will decrease coverage by 0.17%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   73.74%   73.57%   -0.18%     
==========================================
  Files           4        4              
  Lines         617      613       -4     
  Branches      124      124              
==========================================
- Hits          455      451       -4     
- Misses        123      124       +1     
+ Partials       39       38       -1

Impacted Files	Coverage Δ
pyglmnet/base.py	`45.16% <100%> (-3.33%)`	:arrow_down:
pyglmnet/pyglmnet.py	`79.67% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a80848c...0672c6d. Read the comment docs.

tommyod commented 5 years ago

Spent some time reverting the commits related to sklearn - I'm not proud of the resulting git history. Please squash when merging.

I will update docs.

jasmainak commented 5 years ago

Can you also update the Readme and documentation saying we only support python 3 from now on.

tommyod commented 5 years ago

I think the PR is good to go, can you look over it @jasmainak ? There were some issues with CircleCI, and on the webpage is states "Your project references CircleCI 1.0 or it has no configuration. CircleCI 1.0 and projects without configuration files are no longer supported. You must update your project to use CircleCI 2.0 configuration to continue." I'm not experienced with CircleCI, but I suggest we fix it in another PR if troubles persist.

Please squash merge, the history is very ugly.

jasmainak commented 5 years ago

Done, thanks @tommyod

next time I suggest when you are ready you can put [MRG] at the beginning of the title. It's how we usually indicate that it's good to go :)