Python2 import fix in datasets.py

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models

http://glm-tools.github.io/pyglmnet/

MIT License

279 stars 83 forks source link

Closed cxrodgers closed 5 years ago

cxrodgers commented 5 years ago

This PR fixes an import of urllib for Python 2, without compromising Python 3 functionality. https://github.com/glm-tools/pyglmnet/issues/292

jasmainak commented 5 years ago

Is this really necessary? Python 2 is not going to be supported be most libraries soon including numpy. It's going to be a pain to maintain ...

cxrodgers commented 5 years ago

No, it is not necessary. But it might help some people. But I understand if you don't want to include such a workaround.

jasmainak commented 5 years ago

I think getting pretty much anything done in scientific Python 2 would be difficult very soon since numpy won't be supported ...

jasmainak commented 5 years ago

let's close this PR? would be better to focus the efforts on other development aspects than to support this