scipy.special.comb replaces recently-removed scipy.misc.comb

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models

http://glm-tools.github.io/pyglmnet/

MIT License

279 stars 83 forks source link

Closed ghost closed 5 years ago

ghost commented 5 years ago

Fixes #294

jasmainak commented 5 years ago

@peterfoley605 will this work for older versions of scipy? You may have to do some branching to make sure it doesn't break for older versions?

ghost commented 5 years ago

scipy.special.comb was available in 0.14 (https://docs.scipy.org/doc/scipy-0.14.0/reference/generated/scipy.special.comb.html) from May 2014, and requirements.txt has scipy>=0.17, so I don't think it needs older-version logic.

jasmainak commented 5 years ago

okay great merged. Thanks @peterfoley605 !