glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 83 forks source link

Need to install coverage #301

Closed notuntoward closed 4 years ago

notuntoward commented 5 years ago

On the developers page:

http://glm-tools.github.io/pyglmnet/developers.html

It might be worthwhile to mention that the coverage package is needed in order to run:

nosetests . --with-coverage

jasmainak commented 5 years ago

sure this would be a welcome change!

notuntoward commented 5 years ago

Even with coverageinstalled, nosetests don't run correctly. Everything passes if I run:

pytest .\tests\test_pyglmnet.py

But if I try

nosetests . --with-coverage

every function inside of test_pyglmnet.py which is decorated with:

@pytest.mark.parametrize("distr", ALLOWED_DISTRS)

fails.

It seems like the test functions have not actually been ported to nose.

notuntoward commented 5 years ago

Ah, I see. The website documentation is out of sync with the code. Would it be possible to update the website?

jasmainak commented 5 years ago

Yes, we need to make a release soon and that will bring it in sync. It's on my todo ...

jasmainak commented 4 years ago

closing this now as we have made a release now