search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 83 forks source link

Dataset and ex fixes #303

Closed notuntoward closed 5 years ago

notuntoward commented 5 years ago
jasmainak commented 5 years ago

You have flake8 errors. Can you fix them? Thanks!

jasmainak commented 5 years ago

Can you also update whats_new.rst? Thanks

On Mon 3 Jun 2019 at 18:00, notuntoward notifications@github.com wrote:

@notuntoward commented on this pull request.

In pyglmnet/datasets.py https://github.com/glm-tools/pyglmnet/pull/303#discussion_r290055981:

@@ -47,23 +48,22 @@ def fetch_tikhonov_data(dpath='/tmp/glm-tools'): fnames = ['fixations.csv', 'probes.csv', 'spiketimes.csv']

 for fname in fnames:
  • url = os.path.join(base_url, "tikhonov/%s" % fname)
  • url = base_url + "/tikhonov/" + fname

But now I've fixed the flake8 errors

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/glm-tools/pyglmnet/pull/303?email_source=notifications&email_token=ADY6FIUSEYXSZFEXVSYVGZLPYWIAFA5CNFSM4HSOE4R2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2OKLHQ#discussion_r290055981, or mute the thread https://github.com/notifications/unsubscribe-auth/ADY6FIWJDYJLHISM3G42J33PYWIAFANCNFSM4HSOE4RQ .

-- Sent from my iPhone

codecov-io commented 5 years ago

Codecov Report

Merging #303 into master will decrease coverage by 0.11%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   74.27%   74.15%   -0.12%     
==========================================
  Files           4        4              
  Lines         622      623       +1     
  Branches      127      127              
==========================================
  Hits          462      462              
- Misses        123      124       +1     
  Partials       37       37
Impacted Files Coverage Δ
pyglmnet/pyglmnet.py 80.28% <0%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49df45f...c202b4d. Read the comment docs.

jasmainak commented 5 years ago

Thanks a lot for the fixes @notuntoward !

jasmainak commented 5 years ago

Merged after squash and cosmit https://github.com/glm-tools/pyglmnet/commit/c962c840c4669ae69e623a2595eba40ae50e460d. Thanks @notuntoward !