Closed DreHar closed 4 years ago
can you add a test?
PR looks reasonable to me although I didn't take a very close look. Let me know once you've added tests.
Merging #310 into master will increase coverage by
1.03%
. The diff coverage is93.69%
.
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 74.56% 75.59% +1.03%
==========================================
Files 4 4
Lines 629 668 +39
Branches 128 145 +17
==========================================
+ Hits 469 505 +36
- Misses 125 127 +2
- Partials 35 36 +1
Impacted Files | Coverage Δ | |
---|---|---|
pyglmnet/utils.py | 43.13% <100%> (+10.57%) |
:arrow_up: |
pyglmnet/pyglmnet.py | 81.27% <93.2%> (+0.55%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 83b3883...33105af. Read the comment docs.
@pavanramkumar while you're at it don't forget to update whats_new.rst
giving credit to @DreHar for the original PR
Thanks @pavanramkumar and @DreHar !
Add fit_intercept parameter to GLM and GLMCV #308