glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 83 forks source link

include nonzero lambda in glm tests #312

Closed ghost closed 5 years ago

ghost commented 5 years ago

test_glmnet is currently only run with reg_lambda=0., which means things like calls to self._prox effectively have no impact and don't get tested for all ALLOWED_DISTRS.

jasmainak commented 5 years ago

Looks clean, merged. Thanks @peterfoley605 !