search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 83 forks source link

Add number of iterations & add raise error when solver not found. #314

Closed opieters closed 4 years ago

opieters commented 4 years ago

Add variable to store number of iterations & add raise error when solver cannot be identified.

jasmainak commented 4 years ago

We follow pep8 conventions @opieters so Travis will not pass until you conform to that.

opieters commented 4 years ago

Ok, I will modify the code to follow the necessary conventions and try to add a test.

opieters commented 4 years ago

I think all of the issues are fixed now.

codecov-io commented 4 years ago

Codecov Report

Merging #314 into master will increase coverage by 0.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   74.15%   74.52%   +0.36%     
==========================================
  Files           4        4              
  Lines         623      628       +5     
  Branches      127      128       +1     
==========================================
+ Hits          462      468       +6     
  Misses        125      125              
+ Partials       36       35       -1
Impacted Files Coverage Δ
pyglmnet/pyglmnet.py 80.67% <100%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b15c58...46ae019. Read the comment docs.

jasmainak commented 4 years ago

closed by #316