search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 83 forks source link

record number of iterations #316

Closed jasmainak closed 4 years ago

jasmainak commented 4 years ago

@peterfoley @cxrodgers @opieters

can you see if this solves your use-case?

closes https://github.com/glm-tools/pyglmnet/pull/277 https://github.com/glm-tools/pyglmnet/pull/287 https://github.com/glm-tools/pyglmnet/pull/314

codecov-io commented 4 years ago

Codecov Report

Merging #316 into master will increase coverage by 0.4%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #316     +/-   ##
=========================================
+ Coverage   74.15%   74.56%   +0.4%     
=========================================
  Files           4        4             
  Lines         623      629      +6     
  Branches      127      128      +1     
=========================================
+ Hits          462      469      +7     
  Misses        125      125             
+ Partials       36       35      -1
Impacted Files Coverage Δ
pyglmnet/pyglmnet.py 80.71% <100%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7f4ee9...872f19d. Read the comment docs.

jasmainak commented 4 years ago

Merging so we can move on. Feel free to complain if this doesn't solve the issue.

cxrodgers commented 4 years ago

@jasmainak I will definitely check. SFN deadline coming up so it won't be right away, unfortunately. Thanks!