search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 82 forks source link

Add small example of usage in the JOSS paper. #357

Closed geektoni closed 4 years ago

geektoni commented 4 years ago

I have added a small example of how to use pyglmnet in the JOSS paper (by taking inspiration from one of the already existing examples in the gallery).

The final pdf can be found here.

jasmainak commented 4 years ago

thanks a lot @geektoni !

I am just waiting for the editor to give his comments before going ahead and editing the paper :)

geektoni commented 4 years ago

thanks a lot @geektoni !

I am just waiting for the editor to give his comments before going ahead and editing the paper :)

makes sense to me :+1:

geektoni commented 4 years ago

I was thinking about adding also the plot presented in the example to the document, just to give more contest about the code usage. Would it be worth it or does it just bloat the paper?

jasmainak commented 4 years ago

@geektoni have you disabled pushing by maintainers to your branch? Looks like I can't fix the CircleCI issue you got. I'll just open a new PR

geektoni commented 4 years ago

@geektoni have you disabled pushing by maintainers to your branch? Looks like I can't fix the CircleCI issue you got. I'll just open a new PR

mmh the “allow edit feature” is enabled for this PR. No idea why you cannot edit it :/. Go ahead with the new PR since I think it’s faster

jasmainak commented 4 years ago

oh I got the branch name wrong it seems. It's feature/improve-pr not improve-pr. Never mind, we'll continue in the new PR anyway

geektoni commented 4 years ago

Ah I see! I’ll close this one since it not useful anymore.