Closed titipata closed 4 years ago
Merging #359 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 4 4
Lines 678 678
Branches 149 149
=======================================
Hits 513 513
Misses 128 128
Partials 37 37
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0669e72...17cfb07. Read the comment docs.
@jasmainak @pavanramkumar I fixed some text and typos in paper
and a few places in documentation. I think this should addresses the comments in JOSS review.
thank you @titipata! i added some minor wordsmithing changes. @jasmainak looks good to merge for me!
thanks for editing @pavanramkumar! After this PR, it should be ready for JOSS submission. The writing is much better now.
Merged, thanks @titipata and @pavanramkumar !
@jasmainak @pavanramkumar should we tag the reviewer and editor in JOSS to do a final review then?
@titipata I am going to try to see if I can improve the example in the readme. One of the reviewers mentioned it as a "good to have". Then we can reply to the editor in the JOSS issue :) Will try to get it done by tonight.
@jasmainak Awesome! I saw the comment on that. Feel free to tag me to review the PR :)
paper.md