glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 82 forks source link

Update paper.md, mailmap and small URL fix #359

Closed titipata closed 4 years ago

titipata commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #359 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files           4        4           
  Lines         678      678           
  Branches      149      149           
=======================================
  Hits          513      513           
  Misses        128      128           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0669e72...17cfb07. Read the comment docs.

titipata commented 4 years ago

@jasmainak @pavanramkumar I fixed some text and typos in paper and a few places in documentation. I think this should addresses the comments in JOSS review.

pavanramkumar commented 4 years ago

thank you @titipata! i added some minor wordsmithing changes. @jasmainak looks good to merge for me!

titipata commented 4 years ago

thanks for editing @pavanramkumar! After this PR, it should be ready for JOSS submission. The writing is much better now.

jasmainak commented 4 years ago

Merged, thanks @titipata and @pavanramkumar !

titipata commented 4 years ago

@jasmainak @pavanramkumar should we tag the reviewer and editor in JOSS to do a final review then?

jasmainak commented 4 years ago

@titipata I am going to try to see if I can improve the example in the readme. One of the reviewers mentioned it as a "good to have". Then we can reply to the editor in the JOSS issue :) Will try to get it done by tonight.

titipata commented 4 years ago

@jasmainak Awesome! I saw the comment on that. Feel free to tag me to review the PR :)