search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 82 forks source link

DOC: improve readme example #361

Closed jasmainak closed 4 years ago

jasmainak commented 4 years ago

@pavanramkumar @titipata @geektoni here is my attempt at improving the readme example. Let me know what you think

codecov-io commented 4 years ago

Codecov Report

Merging #361 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files           4        4           
  Lines         678      678           
  Branches      149      149           
=======================================
  Hits          513      513           
  Misses        128      128           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c8b834...7c6dc64. Read the comment docs.

pavanramkumar commented 4 years ago

thanks for going the extra mile as always @jasmainak!

jasmainak commented 4 years ago

@titipata I'll go ahead and merge for now. Feel free to make a follow up PR if you want to improve it!

geektoni commented 4 years ago

Looks good to me! :+1: I would just add plt.plot() at the end of the example to actually visualize the plots. If a user copy-pastes the code now he won't see any graph displayed.

titipata commented 4 years ago

Agree with @geektoni, otherwise this looks good to me! I'll make the PR if seeing some more improvement @jasmainak