search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 82 forks source link

Fix problem externals does not get included #374

Closed titipata closed 4 years ago

titipata commented 4 years ago

This was my mistake when adding externals folder. We have to fix the setup.py too.

codecov-io commented 4 years ago

Codecov Report

Merging #374 into master will decrease coverage by 0.88%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   75.66%   74.78%   -0.89%     
==========================================
  Files           4        4              
  Lines         678      686       +8     
  Branches      149      148       -1     
==========================================
  Hits          513      513              
- Misses        128      133       +5     
- Partials       37       40       +3
Impacted Files Coverage Δ
pyglmnet/pyglmnet.py 79.71% <0%> (-1.54%) :arrow_down:
pyglmnet/base.py 48.38% <0%> (+3.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c8b834...e756318. Read the comment docs.

titipata commented 4 years ago

@jasmainak resolve your comments!

jasmainak commented 4 years ago

I’ll merge once CIs are green :)

jasmainak commented 4 years ago

Thanks @titipata !