geektoni commented 4 years ago

Addressing issue #379.

GLM objects can show the current training progress statistics (remaining time, iterations/sec, etc.). This is true also for GLMCV objects.

Add tqdm (https://github.com/tqdm/tqdm/) as a requirement.

geektoni commented 4 years ago

Here a little example about how the user would see it (the screen glitch it is not present in real life and it is an artifact created by the screen recorder).

progress

codecov-commenter commented 4 years ago

Codecov Report

Merging #380 into master will decrease coverage by 0.38%. The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   75.03%   74.64%   -0.39%     
==========================================
  Files           4        4              
  Lines         701      714      +13     
  Branches      150      152       +2     
==========================================
+ Hits          526      533       +7     
- Misses        133      138       +5     
- Partials       42       43       +1

Impacted Files	Coverage Δ
pyglmnet/utils.py	`43.54% <45.45%> (+0.41%)`	:arrow_up:
pyglmnet/pyglmnet.py	`79.96% <100.00%> (+0.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec9cf1c...bd460f1. Read the comment docs.

jasmainak commented 4 years ago

@geektoni need to update the whats_new page

jasmainak commented 4 years ago

Otherwise, LGTM. Can you set the PR to MRG if you're ready?

geektoni commented 3 years ago

Otherwise, LGTM. Can you set the PR to MRG if you're ready?

@jasmainak I've updated some minor things. If you think it's good I'll move to MRG.

jasmainak commented 3 years ago

Thanks heaps @geektoni !!

glm-tools / pyglmnet

[MRG] Show progress when training a GLM object. #380

Codecov Report