search

glm-tools / pyglmnet

Python implementation of elastic-net regularized generalized linear models
http://glm-tools.github.io/pyglmnet/
MIT License
279 stars 82 forks source link

Fix the threshold of the proximal operator #384

Closed AnchorBlues closed 3 years ago

AnchorBlues commented 3 years ago

This is related to https://github.com/glm-tools/pyglmnet/issues/383 .

jasmainak commented 3 years ago

thanks a lot @AnchorBlues for making the pull request. Could we perhaps add a tiny (and fast) test that does a comparison with scikit-learn? Ideally, the test should fail on master but pass on your pull request branch

AnchorBlues commented 3 years ago

Could we perhaps add a tiny (and fast) test that does a comparison with scikit-learn?

This(test_compare_sklearn) is the test that fills the conditions you mentioned. Before my fix, AssertionError is raised by executing this test.

pavanramkumar commented 3 years ago

Also, would be great to add the reference to the tutorial!

jasmainak commented 3 years ago

@AnchorBlues could you also update whats_new.rst? Thanks so much!

AnchorBlues commented 3 years ago

@jasmainak I updated whats_new.rst. Please check if my update is appropriate.

jasmainak commented 3 years ago

Perfect, thanks a lot @AnchorBlues !

jasmainak commented 3 years ago

Also, would be great to add the reference to the tutorial!

I took a look and it seems there is nothing to update?

jasmainak commented 3 years ago

@AnchorBlues for some reason, you don't figure in the contributors list of Pyglmnet: https://github.com/glm-tools/pyglmnet/graphs/contributors. Do we have the right email here: https://github.com/glm-tools/pyglmnet/blob/master/.mailmap#L27 ? It seems to me that the email address you use to make a commit is not added to GitHub. Please take a look here: https://docs.github.com/en/enterprise/2.15/user/articles/adding-an-email-address-to-your-github-account

AnchorBlues commented 3 years ago

@jasmainak Thanks for your review and merging.

Do we have the right email here: https://github.com/glm-tools/pyglmnet/blob/master/.mailmap#L27 ? It seems to me that the email address you use to make a commit is not added to GitHub.

Yes, I have both email addresses.
I registered the email address with GitHub that I did not register yet.

jasmainak commented 3 years ago

perfect, I can see you in the contributors now :)