Closed glmcdona closed 2 years ago
Please let me know if you would like me (us?) to also run this update. Looks great, looking forward to have feedback on multi-envs training :heart:
Hi @glmcdona , just a small remark from me. Many of the changes in this pull request seem to me already too deep implementation details, the kind of things everyone should decide for himself. I would have kept the repo cleaner than that. However, I am not familiar with the repository philosophy, just a first thought.
[UPD] the new tensorboard logging stats are cool
Hi @glmcdona , just a small remark from me. Many of the changes in this pull request seem to me already too deep implementation details, the kind of things everyone should decide for himself. I would have kept the repo cleaner than that. However, I am not familiar with the repository philosophy, just a first thought.
[UPD] the new tensorboard logging stats are cool
Totally agree. Clean and simple for the example I think makes sense. Leave more advanced implementation like this for something like a separate public notebook using the framework. TODO: Refactor the example agent and training script to more minimal.
Updates: