search

glmrvn / Appearance-figma-plugin

Figma plugin. This plugin generates a dark/light theme from your selection.
https://www.figma.com/community/plugin/760927481606931799/Appearance
40 stars 15 forks source link

Suggestion on code cleanup #29

Closed c5inco closed 2 years ago

c5inco commented 2 years ago

Hello! I've been trying out this plugin for the last week and it's super useful for my team's workflow.

However, I was having issues with the dark -> light mode workflow, so I forked the repo and dug into the code. I found that there were different code paths being used. So, I did some refactoring that I think simplifies the code path and makes it that swapping styles is the same implementation for light <-> dark.

Things should work exactly the same from the plugin perspective but now I think it's more reliable when switching themes.

Let me know what you think and thanks so much for making this plugin!

glmrvn commented 2 years ago

Hello! Looks fantastic. Thanks a lot.

c5inco commented 2 years ago

Thanks for accepting! Happy to keep helping out!