search

glob3mobile / g3m

The multiplatform advanced visualization framework
http://www.glob3mobile.com/
Other
117 stars 56 forks source link

Aeroglass glrepeat support clean #170

Open zoltanpillio opened 8 years ago

zoltanpillio commented 8 years ago

We would like to use textures with GL_REPEAT instead of GL_CLAMP_TO_EDGE wrap mode. In this code version TexturesHandler has a new getTextureIDReference method with an additional parameter to control wrap mode.

DiegoGomezDeck commented 8 years ago

I took a quick look and it looks right. @amazingsmash can you check it too?

amazingsmash commented 8 years ago

I haven't tested either but all changes seem logic. Native implementation of GL seems complete.

DiegoGomezDeck commented 8 years ago

I took a quick overview, and it looks right.

BTW, I'd like to remove the GL:: uploadTexture() method without the wrap parameter, and refactor all over around where this method is called. In short, I don't think that any wrap policy could be the default and it has to be set explicitly in all calls to uploadTexture().

@amazingsmash do you agree?

amazingsmash commented 8 years ago

I've already removed those methods, and added a little example over the Gran Canaria island of a repeated texture.

DiegoGomezDeck commented 8 years ago

@amazingsmash I can't believe my eyes, you're working on Saturday! =o)