Handle "99" and "null" electrification types

global-electrification-platform / data-service

Data service of Global Electrification Platform

MIT License

2 stars 4 forks source link

Handle "99" and "null" electrification types #34

Open vgeorge opened 5 years ago

vgeorge commented 5 years ago

As explained here by @alekordESA, features with "99" electrification type in intermediate years should not be displayed or summarized on GEP. Also, no feature can have "null" electrification type.

The expected behavior is:

Halt seeding process when "null" elec. types are found, in any year;
Halt seeding process when "99" elec. types are found on final year;
Nullify features "99" type in intermediate years.

danielfdsilva commented 5 years ago

Since the seeding process takes quite a long time, we shouldn't stop it in this cases. I think the first step of the ingest pipeline should be data validation, which can be done in a much faster way and allow for quicker action.

vgeorge commented 4 years ago

@akorkovelos Can you please confirm that the rule of blocking 99 types on final years is deprecated? We had an e-mail conversation about this where you stated that you had to generate some scenarios with 99 on 2030. The data service is already discarding null types on summaries, the only change here is that we will drop this check when validating the data prior to a ingest.

cc @AndreasSahlberg

AndreasSahlberg commented 4 years ago

Dear all, We will have settlements with FinalElecCode = 99 in the final year (2030) as well. These should be treated the same way as settlements that have FinalElecCode = 99 in the intermediate year (2025). This is because the densification/intensification scenarios do not target 100% electrification in teh end year. Hope this clarifies things.