global-electrification-platform / explorer

Global Electrification Platform (Web)
https://electrifynow.energydata.info/
MIT License
11 stars 7 forks source link

Baseline chart #190

Closed vgeorge closed 5 years ago

vgeorge commented 5 years ago

Please refer to https://github.com/global-electrification-platform/explorer/issues/188.

This is being implemented in parallel with https://github.com/global-electrification-platform/data-service/pull/70, as baseline data is not return by /scenarios/{id} endpoint at develop branch.

When complete, this chart will replace the first pie chart ("People Connected").

vgeorge commented 5 years ago

Discussed this now with @olafveerman, we are keeping the initial approach of implement a stacked bar as described at #188. The popup should include the population connected between timesteps, as this will not be a information easily perceived at the chart.

olafveerman commented 5 years ago

@vgeorge I thought we said that we'd:

vgeorge commented 5 years ago

Sorry, @olafveerman, I misunderstood that. Here is the updated chart:

Screenshot 2019-08-28 20 08 13

vgeorge commented 5 years ago

Popover added, @danielfdsilva. There are still some issues with underlying data, but the general structure is ready to be styled.

danielfdsilva commented 5 years ago

@vgeorge site breaks with the following error, after selecting a country

error TypeError: "can't convert undefined to object"
    renderPopulationPopover Charts.js:161
    render Charts.js:557
    e countries:1
    routerMiddleware middleware.js:25

This happens while connected to the production api

danielfdsilva commented 5 years ago

@vgeorge Popover was styled. There are some problems with the connected population of the last year:

Malawi: image