global-electrification-platform / explorer

Global Electrification Platform (Web)
https://electrifynow.energydata.info/
MIT License
11 stars 7 forks source link

Updates in model configuration files for official launch #201

Closed vgeorge closed 4 years ago

vgeorge commented 4 years ago

There are changes to be made at the model configuration files. This is an issue to coordinate that need to be made so Devseed can reingest them. @akorkovelos, can you please review the following and help me wrap up the changes needed?

carderne commented 4 years ago

@nicolinalindblad @akorkovelos Please loop me in on plans about adding MV lines, as this shouldn't be done until the data and methodology have gone through peer review.

akorkovelos commented 4 years ago

@vgeorge the main changes in the config files are the following:

We (KTH) can work on the first point and re-upload the yml files for all countries on S3. Then we will need your (DevSeed) support for the rest.

Note!

  1. I suggest that we do not add any MV lines (as toggled layer) in this version (see @carderne comment above). We can keep the HV lines from energydata.info or disable them if you think this will cause confusion. Let's discuss this tomorrow in the meeting.
  2. Other toggled layers (e.g. mobile phone coverage, travel time) will have to wait until we have access or can upload/share these data.
  3. Full result files are ok to share. We have observed some discrepancies in the summary files we have uploaded on S3. We do not use these files anywhere at the moment but I am flagging this fyi. We are working on identifying the bug.

We are trying to keep record of loose ends here.

nicolinalindblad commented 4 years ago

@vgeorge and @akorkovelos adding a point to the list.

The disputed area between Sudan and S. Sudan are both a dashed and a solid line- should only be dashed. The same goes for the border between Morocco and Western Sahara.

Capture

vgeorge commented 4 years ago

@nicolinalindblad the map problem was moved to a new issue as it isn't affected by model configuration.

nicolinalindblad commented 4 years ago

Thank you @vgeorge

vgeorge commented 4 years ago

@akorkovelos, as we discussed today, here is a sheet to coordinate better the model config layer updates. Your can add layer configurations for each country:

https://docs.google.com/spreadsheets/d/1N1sXjo2yGNoQdcUPFKq_xr716_FyolkVx-G1L_h-tP8/edit?usp=sharing

Once we have all the details set I'll transfer to the files and reingest.

akorkovelos commented 4 years ago

Naming on lever 2 has been updated. Working on #208.

akorkovelos commented 4 years ago

208 is closed. Config files are now ready - from our (KTH) side - regarding updates on semantics and uploaded on S3.

akorkovelos commented 4 years ago

Following up on the toggle layers. @vgeorge please can you provide an update on the following:

In case layers are not available shall we keep them on the explorer as potential/upcoming options or discard them for the launch? @bpstewar @carderne?

vgeorge commented 4 years ago

@akorkovelos I've finish reingesting the lastest model configuration files from S3. Levers labels and descriptions should be updated now, you can review that part. Additional layers haven't been changed yet, I'm still working on them and will reingest when finished.

akorkovelos commented 4 years ago

A few changes on description of lever 5; yml files have been updated anew and uploaded on S3 under YML files Sep22. Awaiting for a decision on additional layers from @vgeorge. Then config files will be placed in county folders as needed.

vgeorge commented 4 years ago

@akorkovelos, I've ingested the YML files Sep22 of model configuration files. Regarding the maps:

Please let me know if/when you update the files at S3.

akorkovelos commented 4 years ago

@vgeorge, many Healthsites (#170) seem to be missing on the explorer. See below shp Vs Explorer snapshot for Nigeria. Actually I think it is just an overlaying issue. Can we bring healthsites at the top? Similar with wind and grid lines.?

image image

I am removing Topographic (#220), Solar (#184) and Travel time options for now until we figure out a solution. I ll update the config files accordingly. I ll report back on education facilities (#221) asap.

vgeorge commented 4 years ago

I've added a comment on #170. You can leave Healthsites layers as is now. I think we can fix directly at Mapbox Studio and the map key won't change.

akorkovelos commented 4 years ago

New config files including final additional layers for the launch now uploaded on Se under YML files 22Sept_V2. @vgeorge awaiting for re-ingest to provide a final review.

vgeorge commented 4 years ago

I'm sorry, @akorkovelos, I've added the the wrong map key in #221. It is changed now. Could you please update the files? You can use the same folder (_V2), if you prefer.

vgeorge commented 4 years ago

@akorkovelos I've updated the key locally and reingested the configs. All countries are updated now.

akorkovelos commented 4 years ago

@vgeorge Burundi uses still previous config file. Can you please update? Otherwise the rest seem ok!

vgeorge commented 4 years ago

There was an error in the file. I fixed, ingested and updated it at the S3 bucket in folder YML files 22Sept_V2.

vgeorge commented 4 years ago

@akorkovelos Alex, I've just noticed a map key error at the ao-1 file. I've fixed, reingested and updated S3. Could you please review the other countries?

vgeorge commented 4 years ago

I've made a review, all countries have the proper maps keys now.