search

global-electrification-platform / explorer

Global Electrification Platform (Web)
https://electrifynow.energydata.info/
MIT License
10 stars 7 forks source link

Review disputed borders #203

Open vgeorge opened 4 years ago

vgeorge commented 4 years ago

The disputed area between Sudan and S. Sudan are both a dashed and a solid line- should only be dashed. The same goes for the border between Morocco and Western Sahara.

Capture

Originally posted by @nicolinalindblad in https://github.com/global-electrification-platform/explorer/issues/201#issuecomment-531972596

bpstewar commented 4 years ago

This relates to the basemap, doesn't it? What basemap are you using?

vgeorge commented 4 years ago

This is a basemap provided by Mapbox with OSM data, with WB borders applied over it, as discussed at #158. I've disabled the disputed borders layer and the dashed line is gone. I believe this is fixed, please reopen if you find any issue.

cc @nicolinalindblad @bpstewar

bpstewar commented 4 years ago

Vitor, you fixed it in the wrong direction - the solid borders in the Mapbox basemap are incorrect, we need the dashed borders.

The basemap needs to be borderless, and the the WBG borders need to be overlaid, or you need to use the WBG basemap as the basemap

Neutral Color Basemap - https://api.mapbox.com/styles/v1/gsdpm/cir6ljf470006bsmehhstmxeh.html?title=true&access_token=pk.eyJ1IjoiZ3NkcG0iLCJhIjoiY2lqbmN5eG9mMDBndHVmbTU5Mmg1djF6MiJ9.QqFCD7tcmccysN8GUClW8w#1.5/0/0

Full Colour Basemap - https://api.mapbox.com/styles/v1/gsdpm/cioenuwii001maznontujohu8.html?title=true&access_token=pk.eyJ1IjoiZ3NkcG0iLCJhIjoiY2lqbmN5eG9mMDBndHVmbTU5Mmg1djF6MiJ9.QqFCD7tcmccysN8GUClW8w#1.5/0/0

vgeorge commented 4 years ago

@bpstewar

The borders from Mapbox were already hidden and the dashed lines did came from their map. What I did was to hide them, the solid border are from the file provided by Alex at this link:

https://drive.google.com/drive/folders/1N3l1RQOLIDkuRpOUkyfk3iniHhydXBfK

The issue is that the WB borders provided didn't include disputed territories, so we can't style them.

In the current implementation there is no way to fetch layers from different Mapbox accounts, GEP's and the ones your provided. I believe the only approach to solve this for the launch would be to add WB disputed layer data to the current map. Can you provide this file?

bpstewar commented 4 years ago

Sorry for dropping the ball on this, I added a zipfile with the new boundaries at the link below, use the column style to define

https://drive.google.com/drive/folders/1N3l1RQOLIDkuRpOUkyfk3iniHhydXBfK