search

global-electrification-platform / explorer

Global Electrification Platform (Web)
https://electrifynow.energydata.info/
MIT License
10 stars 7 forks source link

One link to datasets (#133) #263

Closed EricSoroos closed 4 years ago

EricSoroos commented 4 years ago

Make a single link to the dataset hosting all of the source data for a model

vgeorge commented 4 years ago

@EricSoroos we should avoid changing sourceData.scenarios as the property name for scenario data, as the change would affect the data service. I pushed changes reverting this and altering the behavior of the button dropdown. Now it will only display a download button if it is available in the model description. The later behavior was to show a disabled button when the link was not available.

I suggest updating the model config files to follow the current naming while @danielfdsilva reviews this PR.

EricSoroos commented 4 years ago

If the pr doesn't work when it's unmerged, it doesn't make sense to revert it, just don't merge it and add something that does. My read of the source is that sourcedata is just passed through as an opaque parameter, so as long as it's json we're good.

vgeorge commented 4 years ago

Properties sourceData.scenarios and sourceData.clusters are part of the model validation schema and used in test fixtures.

EricSoroos commented 4 years ago

So the net result of this PR is a lint commit?

vgeorge commented 4 years ago

Buttons were disabled instead of being hidden when the links were not available.