search

global-water-watch / global-water-watch-website

Global Water Watch website
https://www.globalwaterwatch.io/
2 stars 0 forks source link

fix: Rename ProjectShare to PageShare #171

Closed lsarni closed 1 year ago

lsarni commented 1 year ago

Changes

Before: image

After: image

netlify[bot] commented 1 year ago

Deploy Preview for global-water-watch-website ready!

Name Link
Latest commit f94f63331b4f3141130cce180a420f173e94ef86
Latest deploy log https://app.netlify.com/sites/global-water-watch-website/deploys/6386013794721700088e647b
Deploy Preview https://deploy-preview-171--global-water-watch-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lsarni commented 1 year ago

Looks good. Can you confirm that the dynamic constructed :href is not a security hotspot? The automated check does not like that.

@SiggyF right now "Download as .csv" will never appear on the page because we never pass a downloadUrl. It was introduced in https://github.com/global-water-watch/global-water-watch-website/pull/121 before we had the automated checks. Since it isn't used it isn't a security risk, in the future it is likely this downloadUrl will be something we define internally and that the users can't modify as to introduce malicious HTML.