Feat/GWW-28: Export time series to csv

lsarni commented 1 year ago

The text and placement of the button are open to discussion.

netlify[bot] commented 1 year ago

Deploy Preview for global-water-watch-website ready!

Name	Link
Latest commit	63eed81cbb1c97296be9bbd6432663691ff939b1
Latest deploy log	https://app.netlify.com/sites/global-water-watch-website/deploys/639b3889c103b500089d6c99
Deploy Preview	https://deploy-preview-174--global-water-watch-website.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lsarni commented 1 year ago

Looks good. Where does Fragment come from? Is that a nuxt thing? If a title includes an , character, will it escape it?

@SiggyF the version of vue we are using doesn't support multi-root components, because of that we would have to wrap them on an empty <div> . But if we use <Fragment> we can avoid that empty <div> because a Fragment doesn't get rendered. There are quite a few examples of that on the code.

, isn't escaped, no characters are, the file name will just include the ,. I don't see the problem with it, but do let me know if you think we should escape characters, and which ones.