global-water-watch / global-water-watch-website

Global Water Watch website
https://www.globalwaterwatch.io/
2 stars 0 forks source link

Fix/GWW-155: show the map with only the selected area if there are no reservoirs #189

Closed lsarni closed 1 year ago

lsarni commented 1 year ago

Ticket: GWW-155

Bug: when selecting an area (basin/adm region/custom area) without any reservoirs the backend returned an error and the website got stuck. After changing the backend response, the website didn't got stuck but tried to render the chart without data.

Solution: in combination with #186 when the user selects an area without reservoirs the detail page shows the map with the selected area and no reservoirs. It includes a text under the heading (where we normally have the list of reservoirs) explaining there are no reservoirs in that area. No chart is shown.

image
netlify[bot] commented 1 year ago

Deploy Preview for global-water-watch-website ready!

Name Link
Latest commit 205e6ac8c0acb6ac5de7121e2329ec2f887bcc13
Latest deploy log https://app.netlify.com/sites/global-water-watch-website/deploys/63f50d3dcfbd3b0008244c07
Deploy Preview https://deploy-preview-189--global-water-watch-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication