globalbibletools / gbt

https://interlinear.globalbibletools.com
15 stars 2 forks source link

feat: track gloss history #344

Closed tycebrown closed 9 months ago

tycebrown commented 9 months ago

What has changed

QA Steps

  1. Reset the database to use the updated schema (nx run db:prisma migrate reset)
  2. Query the contents of the GlossHistory table. Confirm that it is empty.
  3. Change the gloss text for a word. Confirm that a new column is added to the GlossHistory table with the updated gloss text.
  4. Then, change the gloss approval state without changing the gloss text. Confirm that a new column in GlossHistory is created with the updated approval state and null for the gloss text.

Post-Deployment

Pertempto commented 9 months ago

I plan to review this in the morning

Pertempto commented 9 months ago

Lol

Whenever a user updates a gloss, a column is added to this table

I think you have a mistake there 😆

that would be QUITE the implementation

Pertempto commented 9 months ago

@arrocke are prisma migrations something that should be included in the Post Deployment section, or are they ran automatically?

arrocke commented 9 months ago

@arrocke are prisma migrations something that should be included in the Post Deployment section, or are they ran automatically?

These are run automatically on merging

Pertempto commented 9 months ago

If you think it's worth the check I can do all the setup on my local env and test it tomorrow.

arrocke commented 9 months ago

@Pertempto @tycebrown I will take a look at this tomorrow