Closed Pertempto closed 7 months ago
@arrocke I've started by attempting to parse out the ref
tags in the LSJ. How do you want me to handle situations where multiple verses are referred to in one ref
? For example "Mat.1:6, 12:3". When the user clicks the link should I try to show both verses in the preview? For the first implementation, could I focus on just showing the first verse of the ref in the preview? I don't want to make this PR overcomplicated.
Please ignore the weird styling, it's just to help me debug.
How do you want me to handle situations where multiple verses are referred to in one ref?
Ideally, we would split this into two links, so Mat.1:6
would be one link and 12:3
a separate link
Ideally, we would split this into two links, so
Mat.1:6
would be one link and12:3
a separate link
Yeah I agree, but that makes parsing much more complicated. I'm not going to attempt that here. We can always improve in the future.
I just realized that you can pass a function to replaceAll
. I'm going to try that, it should make parsing multiple references from one ref
tag much easier.
I've got LSJ parsing working and very basic link functionality working
I still need to render the correct contents using a portal, and get BDB parsing working.
Making good progress...
Still need to handle rendering Hebrew correctly, and parsing BDB references
This is ALMOST ready! :tada:
I'd like to get to this tomorrow, but realistically it might be Wednesday or Thursday. I have a busy week
I'll be out of town next week so I won't be able to apply any changes until the fifteenth
I think all changes have been addressed, I'm going to wait to update seed file until after #382 is merged.
@arrocke we need to update the lexicons on production with
nx import-lsj db
nx import-bdb db
I'll do this later today as well as post release notes to slack
What has changed
Connected Issues
closes #336
QA Steps
nx run db:prisma migrate reset
to reset your DB to the seed file, or runnx import-lsj db
andnx import-bdb db
to update the lexicon entries in your DB.Matthew 1:3
Ἑσρώμ;
NOTE - there may be certain edge cases where the references aren't parsed or handled correctly. Getting the parsing logic correct is tricky. It might be nice to save those remaining edge cases for a separate issue and/or PR, since this one has dragged on so long. I'm pretty sure this PR covers at least 90% of the references correctly.
Post-Deployment