Closed Pertempto closed 8 months ago
@arrocke i know we've had some discussion before about code-cleanup stuff slowing down code review. Hopefully splitting it up into a separate pull request helps resolve that problem. Please let me know your thoughts on this strategy. Does it cause additional problems for you?
It's worked wonders for us at work (@jcampana98 can a test to that 😆), but maybe it's not a good fit for the gbt
project.
What has changed
Added
isOldTestament
helper function.bookId < 40
ONE place, instead of many places.This is a way to move the magic number to only one place.
Connected Issues
None. Recently I've been blessed by the idea that refactoring changes should be kept completely separate from new feature and bug fix changes. It helps the review process go much quicker, because the refactoring diffs aren't mixed in with the actual diffs that change functionality. I got the concept from Kent Beck's Tidy First? book.
We've been trying it out at work and it's reduced review times greatly. This is a tiny code improvement I found while working on #374, so I thought I'd hold it off for a separate PR. We probably should merge this after that one to reduce diffs there.
QA Steps
Post-Deployment