globalbrain / sefirot

Global Brain Design System.
https://sefirot.globalbrains.com
MIT License
151 stars 12 forks source link

refactor(validation): change validator argument types #440

Closed NozomuIkuta closed 8 months ago

NozomuIkuta commented 8 months ago

Resolves #438

This PR changes first argument of validator functions are changed as of type unknown.

I made validator functions return false if type of the passed argument is not expected by them, but should I make them return true instead?

Other details are written as inline comments.

netlify[bot] commented 8 months ago

Deploy Preview for sefirot-story ready!

Name Link
Latest commit 25093f5c2d940b560530c9b6cfd9ab1605ed5a68
Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65a4ef1755f6f70008f1e9e1
Deploy Preview https://deploy-preview-440--sefirot-story.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 8 months ago

Deploy Preview for sefirot-docs ready!

Name Link
Latest commit 25093f5c2d940b560530c9b6cfd9ab1605ed5a68
Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65a4ef1743a3f80008a9f2e4
Deploy Preview https://deploy-preview-440--sefirot-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.