search

globalbrain / sefirot

Global Brain Design System.
https://sefirot.globalbrains.com
MIT License
151 stars 12 forks source link

[SDesc] Add component to show money #461

Closed NozomuIkuta closed 7 months ago

NozomuIkuta commented 7 months ago

The name will SDescMoney which renders Money value like ¥ 23,456 CNY. Maybe extended version of SDescNumber?

kiaking commented 7 months ago

I always wanted this too. And good point about whether we extend other base desc value to do this... 🤔

Need to come up with solid design first. I'll think about it. But at the end, I think it wouldn't be named like <SDescMoney> in Sefirot, because it will be hard to define Money model in Sefirot. That depends too much on use cases.

In stead, I think it would be better to have more generic component which can have prefix, or suffix, and then we can use that component in the apps to display anything.