globalbrain / sefirot

Global Brain Design System.
https://sefirot.globalbrains.com
MIT License
151 stars 12 forks source link

fix(table): use `mini` size for state cell #486

Closed kiaking closed 6 months ago

kiaking commented 6 months ago

This should have been like this from beginning to align the size with pill.

Screenshot 2024-03-05 at 9 44 29
netlify[bot] commented 6 months ago

Deploy Preview for sefirot-docs ready!

Name Link
Latest commit e7631fc6ff155497ddb9a4fb3c6975611067fed9
Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/65e66bb953463d000804d91e
Deploy Preview https://deploy-preview-486--sefirot-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for sefirot-story ready!

Name Link
Latest commit e7631fc6ff155497ddb9a4fb3c6975611067fed9
Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/65e66bb9d9e71b0008dc1bc1
Deploy Preview https://deploy-preview-486--sefirot-story.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brc-dd commented 6 months ago

I think without mini it was better aligned? (I mean it's height was 24px, line height of adjacent columns is also 24px, height of avatar is also 24px)

kiaking commented 6 months ago

Hmmmm good point. In that case, we could increase Pill size to small 🤔 It's a subjective manner but felt like it was too big compared to text, because pill and state looks bigger due to its background color and borders.

But, good point with avatar... For example GitHub has 20px for both pill and avatar, but having bigger avatar makes it easier to see who they are... 🤔 ...

Asana has 20px for pill and 24px for avatar.

Hmmmm... Let me try how it feels like when we have 24px pill 🏃‍♂️

kiaking commented 6 months ago

Yeah I think 24px pill is too big for me 😭 OK, let's go with 20px state for now. I wanna keep avatar a bit bigger since our members photos are very similar and would like to have it big as possible 👀 WDYT?

Screenshot 2024-03-05 at 11 11 26