Custom rootfs support - Githubissues

globalcitizen / lxc-gentoo

lxc-gentoo: Linux Containers Gentoo Guest Template Script

http://globalcitizen.github.com/lxc-gentoo

GNU General Public License v3.0

85 stars 32 forks source link

Custom rootfs support #49

Closed specing closed 11 years ago

specing commented 11 years ago

This fixes Issue #43

The custom rootfs support is command line/env only as you can hardly expect a human to correctly enter a 40-characted file name + path to it.

The configure script will still ask for arch/variant/subarch though it will be ignored.

best used with -q

hopefully the README should display correctly (I escaped _ in $STAGE3_ROOTFS with \ because vim just decided to highlight the rest of the script in bold white).

Note that while it is possible now for this script to generate rootfss for different architectures, there still is no easy way to run them.

globalcitizen commented 11 years ago

Looks pretty reasonable, however:

The documentation doesn't match the code (-t option is present)
Please stop the configure script from asking for irrelevant options when this has been supplied.

Sorry that I cannot test and accept the pull request right now as I have to go off to a hospital for a few hours of fun... but I will do that when you make those two changes.

Thanks.

specing commented 11 years ago

Ah I see, the -t option description stated we don't ask for download related bits

specing commented 11 years ago

This is becoming a monster patch.

specing commented 11 years ago

ping? @globalcitizen

globalcitizen commented 11 years ago

Pong. Apologies, I've been offline a lot this week. Thanks for your efforts. Testing in the next hour or so.