I've done a series of cleanups and fixes to lxc-gentoo and adapted more settings to getops

globalcitizen / lxc-gentoo

lxc-gentoo: Linux Containers Gentoo Guest Template Script

http://globalcitizen.github.com/lxc-gentoo

GNU General Public License v3.0

86 stars 32 forks source link

I've done a series of cleanups and fixes to lxc-gentoo and adapted more settings to getops #74

Closed satmd closed 9 years ago

satmd commented 9 years ago

getopts features: -b for enabling a bridge device -r for setting ROOTFS -c for setting CONFIGFILE -v for setting ARCHVARIANT

cleanup: s/\s*$// (removed trailing whitespaces)

fixes:

disable sysctl initscript
remove dev/shm from lxc configfile because it collides with fstab during boot (this might need review)
symlink /etc/mtab to /proc/self/mounts

globalcitizen commented 9 years ago

Thanks for your work. Overall it looks good though please read through the comments I've made and respond here.

The ones I would like a response for are under 'redundant code' and 'disable sysctl in runlevels', plus the 'etc/mtab' generation issue.

As far as the "coliding with fstab" assertion, the current code apparently works for everyone so I'm against instituting any changes for the moment 'if it aint broke', but happy to hear reasoning.

globalcitizen commented 9 years ago

I'll wait another week or so for a response. After which, I'll consider cherry-picking individual portions of this pull request.

globalcitizen commented 9 years ago

No response to issues.