globalcitizen / taoup

The Tao of Unix Programming (Ruby-powered ANSI colored fortunes)
GNU General Public License v3.0
414 stars 20 forks source link

Encoding flag needed? #1

Closed e12e closed 10 years ago

e12e commented 10 years ago

Hi,

as far as I can tell, a comment indicating that the script is in utf-8 is needed: $ ruby --version ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux] $ ./taoup > /dev/null ./taoup:313: invalid multibyte char (US-ASCII) ./taoup:313: invalid multibyte char (US-ASCII) ./taoup:313: syntax error, unexpected $end, expecting '}' ...d{ " - Douglas Hofstadter, 'Gödel, Escher, Bach: An Eternal... ...
$ git diff diff --git a/taoup b/taoup index 4b20c0d..ac3cdc0 100755 --- a/taoup +++ b/taoup @@ -1,4 +1,5 @@

!/usr/bin/ruby

+# encoding: utf-8

require 'ansi/code'

$ ./taoup > /dev/null

(No error output)

FYI, my locale settings:

$ locale LANG=en_GB.UTF-8 LANGUAGE= LC_CTYPE="en_GB.UTF-8" LC_NUMERIC="en_GB.UTF-8" LC_TIME="en_GB.UTF-8" LC_COLLATE="en_GB.UTF-8" LC_MONETARY="en_GB.UTF-8" LC_MESSAGES="en_GB.UTF-8" LC_PAPER="en_GB.UTF-8" LC_NAME="en_GB.UTF-8" LC_ADDRESS="en_GB.UTF-8" LC_TELEPHONE="en_GB.UTF-8" LC_MEASUREMENT="en_GB.UTF-8" LC_IDENTIFICATION="en_GB.UTF-8" LC_ALL=

globalcitizen commented 10 years ago

Interesting. No such issue here, I have added it.