search

globaldothealth / adtl

Another data transformation language
https://adtl.readthedocs.io
MIT License
1 stars 0 forks source link

Skip fields #67

Closed pipliggins closed 1 year ago

pipliggins commented 1 year ago

This PR allows certain fields, or field patterns, to be skipped if not present in the data, to use when a single study has multiple datasets with a varying amount of data entry.

pipliggins commented 1 year ago

@abhidg - this works, but it's taking nearly double the time to run on larger datasets. Any ideas which bit might be slowing it down/ ways to get the speed back up?

codecov-commenter commented 1 year ago

Codecov Report

Merging #67 (835c69d) into main (603fe6f) will decrease coverage by 1.48%. The diff coverage is 70.90%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   89.10%   87.63%   -1.48%     
==========================================
  Files           4        4              
  Lines         716      760      +44     
==========================================
+ Hits          638      666      +28     
- Misses         78       94      +16
Impacted Files Coverage Δ
adtl/__init__.py 82.31% <66.66%> (-2.16%) :arrow_down:
tests/test_parser.py 100.00% <100.00%> (ø)
abhidg commented 1 year ago

Thanks!