globaldothealth / fhirflat

ISARIC 3.0 Pipeline - FHIRFlat
https://fhirflat.readthedocs.io
MIT License
0 stars 0 forks source link

Format dates to ISO8601 in ingestion #37

Closed pipliggins closed 5 months ago

pipliggins commented 5 months ago

Adds arguments to convert_data_to_flat function for the current date format and timezone.

On ingestion dates/datetimes are converted to the ISO8601 standard.

FHIRflat natively has validation check that date format matches YYYY-MM-DD, but doesn't check for a timezone if a time is provided (https://github.com/nazrulworld/fhir.resources/blob/3f61a5e7963657ed354e2d02b938c62569583299/fhir/resources/fhirtypes.py#L518).

Chose not to put datetime options in google sheets mapping files to keep files streamlined.

Fixes #33, related to #32

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.24%. Comparing base (a029781) to head (5bb4d54).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 92.08% 92.24% +0.15% ========================================== Files 39 39 Lines 1580 1611 +31 ========================================== + Hits 1455 1486 +31 Misses 125 125 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.