globaldothealth / list

Repository for Global.health: a data science initiative to enable rapid sharing of trusted and open public health data to advance the response to infectious diseases.
MIT License
39 stars 7 forks source link

Beta Bug Bash + Homestretch Housekeeping #1508

Closed joe-brilliant closed 3 years ago

joe-brilliant commented 3 years ago

(In particular, the Data link previews still say "Curator portal" etc on slack etc. The Map previews look good on Slack)

https://cards-dev.twitter.com/validator https://www.linkedin.com/post-inspector/inspect/ https://api.slack.com/methods/chat.unfurl/test https://developer.apple.com/library/archive/technotes/tn2444/_index.html

https://global.health/ https://global.health/research/ https://global.health/about/ https://data.covid-19.global.health/ https://data.covid-19.global.health/cases https://map.covid-19.global.health/ https://map.covid-19.global.health/#country https://map.covid-19.global.health/#region https://map.covid-19.global.health/#coverage

rkassa commented 3 years ago

Update from my end:

  • [x] Fix visualization issues with Regional view on Map
  • [x] Update URLs for Country View and Regional view to be more accurate and descriptive (currently: http://covid-19.global.health/#cumulative and http://covid-19.global.health/#cases)
  • [x] Add the top nav link on Map that links to Data (similar to the corresponding link on Data top nav that links to Map)
  • [x] Make upper left "G.h" icon on Map go to homepage (marketing website)
  • [x] Add link to "Privacy Policy" under "Get Involved" webform on marketing website
  • [x] Optimize site loading speed for marketing website (especially "About")
  • [x] Get Involved link on Research goes to dev URL
joe-brilliant commented 3 years ago

I am still noticing somewhat slow loading times on the marketing website, particularly "About" @rkassa. Are you? Would you mind taking a look and maybe revisiting compression once we add new logos ? Thank you!

rkassa commented 3 years ago

Additional fixes —

WeronikaMichaluk commented 3 years ago

Update from HTD, Tasks that are done:

  • [x] Make upper left "G.h" icon on Data go to homepage (marketing website)

  • [x] Update links on Data left nav sidebar (when opened) and profile modal (currently they link to old TOU, PP, etc

  • [x] Change "About Global.Health" in profile modal on Data to "Global.health" and fix link to go to "About page"

  • [x] Remove "Report an issue" from profile modal on Data

  • [x] Add links to TOU and PP in login/sign up interstitial page

  • [x] Update all partner logos on homepage, about, and sign up interstitial (Updated on Data website)

  • [x] Fix top justification of signup interstitial (cuts off at the top)

  • [x] Fix text field alignment on email signup form (crops a bit at the bottom?)

  • [x] Confirm iubenda GDPR and cookie policy pop up is implemented and behaving correctly

GREAT JOB @maciekz1996 and @sergioloporto !!!

rkassa commented 3 years ago

Additional fixes @joe-brilliant :

  • [x] Ensure all text font colors are consistent on About (specifically Emily Cohn's title)
  • [x] Change homepage footer copyright text from "Copyright 2021, Boston Children's Hospital" to just "Copyright 2021"
joe-brilliant commented 3 years ago

@WeronikaMichaluk @rkassa @calremmel @maciekz1996 @sergioloporto added a few new items here. If you see any new issues is beta feedback please feel free to add. Also still getting slow loading time on marketing website, maybe let's update on global.health proper and test?

maciej-zarzeczny commented 3 years ago

@joe-brilliant

Todays update from HTD:

joe-brilliant commented 3 years ago

Thanks @maciekz1996 !!

maciej-zarzeczny commented 3 years ago

@joe-brilliant

Update from HTD:

  • [x] Replace Harvard logo on login / landing page with HMS logo
  • [x] Newsletter opt in checkbox text on login / landing page should read "I agree to be added to the Global.health newsletter"
joe-brilliant commented 3 years ago

@WeronikaMichaluk @sergioloporto @maciekz1996, we added a few more small bugs to the BBB list above. When you sign on can you please take a look and get started with any that you can? One that we may need your help with is " Confirm we are tracking email addresses of users who DL the dataset", @calremmel is writing up a ticket now. Thanks everyone, home-stretch!

joe-brilliant commented 3 years ago

@WeronikaMichaluk @sergioloporto @maciekz1996 we could also use your help with confirming and testing all social share preview / metadata, added details to the tickbox above, copied here (cc: @rkassa)

Verify all main Global.health domain card previews function correctly on Twitter, LinkedIn, Slack, and iMesssage etc

(In particular, the Data link previews still say "Curator portal" etc on slack etc. The Map previews look good on Slack)

https://cards-dev.twitter.com/validator https://www.linkedin.com/post-inspector/inspect/ https://api.slack.com/methods/chat.unfurl/test https://developer.apple.com/library/archive/technotes/tn2444/_index.html

https://global.health/ https://global.health/research/ https://global.health/about/ https://data.covid-19.global.health/ https://data.covid-19.global.health/cases https://map.covid-19.global.health/ https://map.covid-19.global.health/#country https://map.covid-19.global.health/#region https://map.covid-19.global.health/#coverage

@Mougk can you suggest new language for Data page previews, and confirm this preview language for Map is ok "Explore an interactive map of COVID-19 case data including information on the Variants of Concern"

rkassa commented 3 years ago

Update:

  • [x] Unhide FAQ in website footer
  • [x] Add JHU to Data Acknowledgments https://coronavirus.jhu.edu/map.html (list is updated from google sheet)
  • [x] Embed YouTube Video on HP upon receipt #1381 (placeholder is in place on dev)
  • [x] Test GA #1524 (confirmed on g.h marketing website. feel free to login to analytics.google.com and look at data @joe-brilliant)
  • [x] When viewing homepage on mobile “explore data” should go under the text, not the video
  • [x] Verify all main Global.health domain card previews function correctly on Twitter, LinkedIn, Slack, and iMesssage etc

global.health —

Screen Shot 2021-02-21 at 1 43 41 PM

map.covid-19.global.health — Screen Shot 2021-02-21 at 3 42 07 PM

data.covid-19.global.health — @calremmel PR is open for social cards meta tag fix for Data: https://github.com/globaldothealth/list/pull/1587

joe-brilliant commented 3 years ago

Thanks @rkassa ! Can we test and verify previews for these links as well?

https://global.health/research/ https://global.health/about/

joe-brilliant commented 3 years ago

added a sub task for the logo link issue on Map above in the master list @rkassa ^

rkassa commented 3 years ago

https://global.health/research/ https://global.health/about/

confirming that both are good to go ✔️

rkassa commented 3 years ago

Also fixed — on dev, test and prod

joe-brilliant commented 3 years ago

@rkassa just to confirm, if we can tweak the vid + text alignment on HP so the tops appear to be aligned (even if they are technically are : ) that would be great even as a bandaid fix so it doesn't distract. Thank you!

joe-brilliant commented 3 years ago

@sergioloporto @rkassa @maciekz1996 one small cosmetic change to Map: can we change the font on the Map help modal to be the same as the font on the Data help modal? Added to list above. Thanks!

https://www.dropbox.com/s/vz2vwxkk9pmexbr/Screen%20Shot%202021-02-22%20at%209.14.11%20PM.png?dl=0 https://www.dropbox.com/s/e0bu3h4pqa9bo6v/Screen%20Shot%202021-02-22%20at%209.14.41%20PM.png?dl=0

joe-brilliant commented 3 years ago

@rkassa one small change I wasn't able to fix on Pantheon: Change "Global.Health" to "Global.health" on Terms of Use page header

joe-brilliant commented 3 years ago

@rkassa I think we can put BBB to bed after we merge and deploy these last two finishing touches? LMK when we're G2G!

Change font on Map help modal to be the same as the font on the Data help modal https://www.dropbox.com/s/vz2vwxkk9pmexbr/Screen%20Shot%202021-02-22%20at%209.14.11%20PM.png?dl=0 https://www.dropbox.com/s/e0bu3h4pqa9bo6v/Screen%20Shot%202021-02-22%20at%209.14.41%20PM.png?dl=0

Change "Global.Health" to "Global.health" on Terms of Use page header

joe-brilliant commented 3 years ago

@rkassa is the map help text font bug as good as bashed? Last one!

rkassa commented 3 years ago

@joe-brilliant Font fix is ready in this PR: https://github.com/globaldothealth/viz/pull/100