globaldothealth / list

Repository for Global.health: a data science initiative to enable rapid sharing of trusted and open public health data to advance the response to infectious diseases.
MIT License
39 stars 7 forks source link

dev: add RECAPTCHA environment variables #2897 #2908

Closed abhidg closed 1 year ago

abhidg commented 1 year ago

This fixes loading the portal when running locally, but does not affect the dev deployment, which is still broken. I checked the EKS deployment and it sets RECAPTCHA_SITE_KEY, which should be read by the curator service, but is not.

edit: Interestingly, if I change the REACT_APP_RECAPTCHA_SITE_KEY to RECAPTCHA_SITE_KEY everywhere, the portal does not work locally. Not sure why that is.

codecov-commenter commented 1 year ago

Codecov Report

Merging #2908 (889a305) into main (aa9388c) will decrease coverage by 0.18%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   60.51%   60.33%   -0.19%     
==========================================
  Files          21       21              
  Lines        1312     1316       +4     
  Branches      198      199       +1     
==========================================
  Hits          794      794              
- Misses        518      522       +4     
Impacted Files Coverage Δ
...cation/curator-service/api/src/controllers/auth.ts 44.41% <0.00%> (-0.48%) :arrow_down:
...ation/curator-service/api/src/controllers/cases.ts 48.17% <0.00%> (ø)
...ation/curator-service/api/src/controllers/users.ts 67.92% <ø> (ø)
verification/curator-service/api/src/model/user.ts 66.66% <ø> (ø)
...ervice/api/src/util/single-window-rate-limiters.ts 37.50% <ø> (ø)
...ation/curator-service/api/src/util/validate-env.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.