globaldothealth / list

Repository for Global.health: a data science initiative to enable rapid sharing of trusted and open public health data to advance the response to infectious diseases.
MIT License
39 stars 7 forks source link

#2840 - age display bug #2912

Closed maciej-zarzeczny closed 1 year ago

maciej-zarzeczny commented 1 year ago

Changes

abhidg commented 1 year ago

@maciej-zarzeczny there is a failing test case, there needs to be a space on either side of the hyphen in the formatting, otherwise :+1:

maciej-zarzeczny commented 1 year ago

@abhidg Thanks for the review, I've missed that while changing the function. It should be fixed now

codecov-commenter commented 1 year ago

Codecov Report

Merging #2912 (f10e87a) into main (93e2dc8) will decrease coverage by 3.63%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   60.33%   56.69%   -3.64%     
==========================================
  Files          21      110      +89     
  Lines        1316     3457    +2141     
  Branches      199     1097     +898     
==========================================
+ Hits          794     1960    +1166     
- Misses        522     1497     +975     
Impacted Files Coverage Δ
...on/curator-service/ui/src/components/App/index.tsx 87.39% <0.00%> (ø)
...ui/src/components/LinelistTable/helperFunctions.ts 50.00% <ø> (ø)
...ion/curator-service/ui/src/components/ViewCase.tsx 80.79% <ø> (ø)
...-service/ui/src/components/util/helperFunctions.ts 72.22% <71.42%> (ø)
...-service/ui/src/components/LinelistTable/index.tsx 51.23% <100.00%> (ø)
...r-service/api/src/util/validate-recaptcha-token.ts
verification/curator-service/api/src/model/user.ts
...ation/curator-service/api/src/controllers/cases.ts
...n/curator-service/api/src/model/failed_attempts.ts
...urator-service/api/src/clients/aws-batch-client.ts
... and 126 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.