search

globaldothealth / list

Repository for Global.health: a data science initiative to enable rapid sharing of trusted and open public health data to advance the response to infectious diseases.
MIT License
39 stars 7 forks source link

Generate acronyms for preexisting conditions #619

Closed attwad closed 4 years ago

attwad commented 4 years ago

So that the suggest box can suggest using those acronyms.

sratcliffe118 commented 4 years ago

@attwad do we need someone from BCH or a set of curators to take a pass through these to confirm they make sense?

attwad commented 4 years ago

The file is here: https://github.com/globaldothealth/list/blob/main/suggest/preexisting_conditions.txt

We have about 9K suggestions in this dialog, a good thing would be for someone knowledgeable to have a pass at it first and remove some of the cruft.

Then we have two choices, do we always want to see the acronyms in the form and the details pages? if so we have to generate them and store them in the same file. Otherwise we can generate the acronyms only for the suggest input. Either way I think we should try to just auto-generate them and we can manually apply fixes for those who ended up wrong based on feedback from curators.

My personal take: generate all acronyms automatically and show them everywhere next ot the name, example: "Brucella abortus brucellosis" -> "Brucella abortus brucellosis (BAB)".

sg?

sratcliffe118 commented 4 years ago

SG, @lagood1 would you be able to take a pass through?

"Brucella abortus brucellosis" -> "Brucella abortus brucellosis (BAB)". I agree with this @attwad to confirm, if a curator was to search BAB, this option would come up? If so then I think this gives us what we need

attwad commented 4 years ago

SG, @lagood1 would you be able to take a pass through?

"Brucella abortus brucellosis" -> "Brucella abortus brucellosis (BAB)". I agree with this @attwad to confirm, if a curator was to search BAB, this option would come up? If so then I think this gives us what we need

Yes it would suggest it.

sratcliffe118 commented 4 years ago

Great, that approach LGTM

On Mon, Jul 27, 2020 at 12:32 PM Timothé notifications@github.com wrote:

SG, @lagood1 https://github.com/lagood1 would you be able to take a pass through?

"Brucella abortus brucellosis" -> "Brucella abortus brucellosis (BAB)". I agree with this @attwad https://github.com/attwad to confirm, if a curator was to search BAB, this option would come up? If so then I think this gives us what we need

Yes it would suggest it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/globaldothealth/list/issues/619#issuecomment-664342456, or unsubscribe https://github.com/notifications/unsubscribe-auth/APCG7P6SASWXMAVBIZQM7B3R5VQVTANCNFSM4PGXJGRQ .

attwad commented 4 years ago

I've added a script and generated the list of basic acronyms for preexisting conditions, whoever does a pass can give some feedback, I can amend accordingly.

lagood1 commented 4 years ago

@sratcliffe118 @attwad Yes, I will take a look and get the edited file back to you